Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #7189 Update self-host google fonts exclusion #7194

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Closes #7189 Update self-host google fonts exclusion #7194

merged 4 commits into from
Dec 19, 2024

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Dec 17, 2024 •
edited
Loading

Description

Fixes #7189

Type of change

Detailed scenario

It's now possible to exclude based on any element in the HTML tag for google fonts instead of only the URL.

Technical description

Documentation

Updated the code to use the full HTML tag as the subject instead of only the URL

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Dec 17, 2024
@remyperona remyperona added this to the 3.18 milestone Dec 17, 2024
@remyperona remyperona self-assigned this Dec 17, 2024
@remyperona remyperona changed the base branch from develop to feature/host-google-fonts December 17, 2024 18:29
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -0.10%) ✅ 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eca50d3) 38660 17083 44.19%
Head commit (7806568) 38660 (+0) 17083 (+0) 44.19% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7194) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codacy-production Codacy Production
Copy link

codacy-production bot commented Dec 17, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -0.10%) ✅ 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eca50d3) 38660 17083 44.19%
Head commit (2591bff) 38660 (+0) 17083 (+0) 44.19% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7194) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@remyperona remyperona marked this pull request as ready for review December 17, 2024 18:47
@jeawhanlee
Copy link
Contributor

@remyperona Don't we also need to update WP_Rocket\Engine\Optimization\GoogleFonts\{Combine, CombineV2}?

@remyperona
Copy link
Contributor Author

You're right I forgot about it, it's updated

@remyperona remyperona requested a review from a team December 19, 2024 14:25
hanna-meda
hanna-meda approved these changes Dec 19, 2024
View reviewed changes
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @remyperona, for this PR.
Confirming that we can now use filter to exclude GFs based on any attribute in the HTML tag.
testrail-report-672.pdf

@hanna-meda hanna-meda merged commit a60bcda into feature/host-google-fonts Dec 19, 2024
13 checks passed
@hanna-meda hanna-meda deleted the enhancement/7189-exclusion-update branch December 19, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanna-meda hanna-meda hanna-meda approved these changes

@jeawhanlee jeawhanlee jeawhanlee approved these changes

Assignees

@remyperona remyperona

Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
3.18
Development

Successfully merging this pull request may close these issues.

3.18 - Exclusions part enhancement
3 participants
@remyperona @jeawhanlee @hanna-meda